Skip to content

Conversation

@adrianimboden
Copy link

I start to use hermetic python environment and saw #929.

It mostly works, but in my case I use pkg_zip instead of pkg_tar.

4eed546 implements raw_symlink/ support for pkg_tar.
This MR adds the same functionality for pkg_zip.

The exception when the feature is not implemented yet:

Exception: ('Unknown type for manifest entry:', ManifestEntry<{'type': 'raw_symlink', 'dest': 'system_impl.runfiles/_main/example/_impl_py_client_install.venv/bin/python3', 'src': 'bazel-out/k8-fastbuild/bin/example/_impl_py_client_install.venv/bin/python3', 'mode': '0555', 'user': None, 'group': None, 'uid': None, 'gid': None, 'origin': '@@//example:system_impl'}>)

Copy link
Collaborator

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will wait to let @aiuto review before merging.

@cgrindel
Copy link
Collaborator

@adrianimboden It looks like there may be some linting issues. Can you investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants