Skip to content

Conversation

@Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented May 15, 2023

The dev_io_bazel_rules_kotlin workspace name doesn't exist anymore and can just be replaced with the default io_bazel_rules_kotlin one.

@restingbull
Copy link
Collaborator

restingbull commented May 16, 2023

Nope -- we've still got hard coded references that need to be removed.

The rename was/is necessary to prevent pulling incorrect deps in during development -- it's not that dev_io_bazel_rules_kotlin is defined, it's that it isn't io_bazel_rules_kotlin.

I found two more references recently -- still cleaning up.

@Bencodes Bencodes force-pushed the rename-dev_io_bazel_rules_kotlin-io_bazel_rules_kotlin branch from 3f593c8 to c2e3436 Compare May 23, 2023 23:58
@restingbull restingbull merged commit b67dd8d into master Jul 7, 2023
@restingbull restingbull deleted the rename-dev_io_bazel_rules_kotlin-io_bazel_rules_kotlin branch July 7, 2023 20:03
nkoroste added a commit that referenced this pull request Jul 26, 2023
…idanceKotlin_upstream

* upstream/master: (51 commits)
  Expose ksp_version (#989)
  Bump quick guide to use v1.8 (#987)
  Fail CI if the docs are outdated (#961)
  Rename dev_io_bazel_rules_kotlin -> io_bazel_rules_kotlin (#973)
  update stardoc to 0.5.6 (#986)
  fix readme about kotlinc_opts and javac_opts (#984)
  Update README with KSP support (#983)
  Regenerate the docs (#980)
  Update the README.md with the latest dev override config (#981)
  Remove opts.release.bzl which is no longer being used (#982)
  Remove print warning from kt_download_local_dev_dependencies (#974)
  Avoid creating duplicate android_sdk_repositories (#978)
  Normalize label (#968)
  Generate koltinc options (#962)
  Restore neverlink on compiler. (#977)
  Use the mnemonic for worker keys (#976)
  Update KtLint to 0.49.1 (#970)
  Add support for -Xuse-fir-lt (#972)
  Support -Xenable-incremental-compilation (#971)
  Update to Kotlin 1.8.21 (#969)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants