Support using --jvmopt with kt_jvm_test #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mai93
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
Bencodes
approved these changes
Jun 21, 2022
Bencodes
approved these changes
Jun 24, 2022
|
Looks like this change is not compatible with Bazel 4.x: https://buildkite.com/bazel/rules-jvm-external/builds/2741#0181ce76-75c9-4e56-89f6-5af0723beab3 Is there any way we could make this backwards compatible? |
copybara-service bot
pushed a commit
to bazelbuild/intellij
that referenced
this pull request
Jul 12, 2022
rules_kotlin now [support using `--jvmopt` with `kt_jvm_test`](bazelbuild/rules_kotlin#782) . PiperOrigin-RevId: 460524616
copybara-service bot
pushed a commit
to bazelbuild/intellij
that referenced
this pull request
Jul 13, 2022
rules_kotlin now [support using `--jvmopt` with `kt_jvm_test`](bazelbuild/rules_kotlin#782) . PiperOrigin-RevId: 460524616
copybara-service bot
pushed a commit
to bazelbuild/intellij
that referenced
this pull request
Jul 13, 2022
rules_kotlin now [support using `--jvmopt` with `kt_jvm_test`](bazelbuild/rules_kotlin#782) . PiperOrigin-RevId: 460731413
mai93
added a commit
to bazelbuild/intellij
that referenced
this pull request
Jul 20, 2022
rules_kotlin now [support using `--jvmopt` with `kt_jvm_test`](bazelbuild/rules_kotlin#782) . (cherry picked from commit 8179705)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the JVM options specified via --jvmopt to the
jvm_flagsofkt_jvm_testtargets.