Mixed source compile test reproducing issues/707 #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
force-pushed
the
restingbull/mixed-source-test
branch
from
1c34310 to
696b087
Compare
* Integration test helpr RulesKotlinWorkspace
restingbull
force-pushed
the
restingbull/mixed-source-test
branch
from
696b087 to
c907eb4
Compare
cgruber
approved these changes
Apr 7, 2022
|
|
||
| kt_jvm_test( | ||
| name = "WriteWorkspaceTest", | ||
| size = "enormous", |
| @@ -0,0 +1,71 @@ | |||
| package io.bazel.kotlin.integration | |||
|
|
|||
| import com.google.common.truth.Truth | |||
| import java.nio.file.StandardOpenOption.CREATE_NEW | ||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| class RulesKotlinWorkspace private constructor( |
There was a problem hiding this comment.
Can we start adding some class level kdocs, at least for new types please?
| import java.time.Instant | ||
| import kotlin.streams.toList | ||
|
|
||
| object WriteWorkspace { |
There was a problem hiding this comment.
The naming of this singleton is a wee bit weird - but I really like the dsl.
A few example usages in a kdoc here would be super handy, so someone isn't hunting down examples in the tests.
Bencodes
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#707