Use JavaPersistantWorker, create new kotlinc every invocation #703
Conversation
|
|
||
| load( | ||
| "@build_bazel_rules_android//android:rules.bzl", | ||
| "android_ndk_repository", |
There was a problem hiding this comment.
The ndk rules are a mess. Don't work past 27 afaict.
| fun exec(errStream: java.io.PrintStream, vararg args: kotlin.String): ExitCode { | ||
| class BazelK2JVMCompiler { | ||
| fun exec(errStream: java.io.PrintStream, vararg args: String): ExitCode { | ||
| System.setProperty("zip.handler.uses.crc.instead.of.timestamp", "true") |
There was a problem hiding this comment.
This is painful (that it's set as a global property in an exec() method I mean, nothing to be done about that if we want to ensure it, I suspect)
There was a problem hiding this comment.
It also doesn't work. Will remove.
| while (true) { | ||
| WorkResponse.parseDelimitedFrom(stdOut.input) | ||
| ?.let(responses::add) | ||
| ?: break |
There was a problem hiding this comment.
Ok, I like this sneaky little pattern.
There was a problem hiding this comment.
It's very jetbrains kotlin. Been reading too much code from there.
| println("sequence $this") | ||
| } | ||
| } | ||
| }.associateBy { wr -> |
There was a problem hiding this comment.
wr? I know you didn't name it here, but can you drive-by rename with something more clear?
| fun waitForStdOut() { | ||
| while (stdOut.input.available() != 0) { | ||
| Thread.onSpinWait() | ||
| Thread.sleep(1) // don't starve other processes. |
There was a problem hiding this comment.
Doesn't doing a Thread.sleep(1) more or less do as much as onSpinWait() or more? As in, if you have sleep(1) do you still need onSpinWait()?
There was a problem hiding this comment.
Hm. I did this as the tests kept hanging.
| * @param captureIO to avoid writing stdout and stderr while executing. | ||
| * @param cpuTimeBasedGcScheduler to trigger gc cleanup. | ||
| */ | ||
| class JavaPersistentWorker( |
There was a problem hiding this comment.
Why the rename here? Is this naming relevant to "java vs. js or llvm/native"? Or java in some other sense?
There was a problem hiding this comment.
Ah, I had named the other Kotlin for coroutines. Will fix.
restingbull
force-pushed
the
restingbull/652
branch
from
4b5775e to
d4d3d41
Compare
Switch to java implementation of the PersistentWorker, move the coroutine impl to side pending investigation
* Set IO to track thread local when capturing stdout and stderr * Small threading fixes in the test structure (threads push things harder tha coroutines)
restingbull
force-pushed
the
restingbull/652
branch
from
d4d3d41 to
92890c1
Compare
2 participants
K2JVMCompileron each invocation to avoid keeping thread localszip.handler.uses.crc.instead.of.timestampas a hail mary to prevent corruptionandroid_ndkfrom examples, as no example uses it... and it's broken for later versions of the android ndk.