Pass strict_deps flag to java compiler in JavaBuilder flow #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkumar9t2
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
restingbull
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently disabling strict deps in Kotlin toolchain (
experimental_strict_kotlin_deps = "off") has no effect when ABI jars compilation is enabled. Targets previously compiling with strict_deps disabled fails to build when ABI jars are enabled.This PR fixes it by passing the Kotlin toolchain flag to underlying
java_common.compileto unify the behavior.