Skip to content

Fix concurrency for multiplex #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2021
Merged

Fix concurrency for multiplex #498

merged 3 commits into from
Mar 8, 2021

Conversation

restingbull
Copy link
Collaborator

  • Tucked it behind a flag
  • Ignore compose at present for releases.

@restingbull restingbull mentioned this pull request Mar 8, 2021
Closed
jongerrish
jongerrish approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@jongerrish jongerrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patched this is and works on our repo.

Build seems to be about 20% slower than without multiplex workers but since this is behind a flag I think there is value in merging to allow us to profile and improve it.

@restingbull restingbull merged commit af9596b into bazelbuild:master Mar 8, 2021
@restingbull restingbull deleted the restingbull/494-use-buffer branch March 8, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@jin jin Awaiting requested review from jin

@timpeut timpeut Awaiting requested review from timpeut

1 more reviewer

@jongerrish jongerrish jongerrish approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@restingbull @jongerrish