Fix non-file inclusion into runfiles for data. #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
requested review from
ahumesky,
cgruber,
Bencodes and
nkoroste
as code owners
restingbull
changed the title
…ata as sources for runfiles.
restingbull
force-pushed
the
restingbull/data-test
branch
from
8fc422f to
9e0932f
Compare
Bencodes
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1348
Dug up more of the magic behind the deprecated
collect_default(it really did do fair amount of work...) -- previous code would only pull in files (whoops) and not theDefaultInfofor targets indata.runtime_depsanddataas sources for runfiles.