Ensure that associates are being included in the source dep_infos list #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber,
restingbull and
nkoroste
as code owners
|
@rbeazleyspot mind taking a look at this since you last changed this code? |
|
🫡 |
|
any other flags set, eg experimental_strict_associate_dependencies ? |
|
@rbeazleyspot We do also set |
restingbull
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring that the top-level dep_infos list contains the complete set of deps collected from both
associatesanddeps. Without this we have modules in our codebase that fail to compile due to jars missing from the classpath.I'm only able to encounter this issue with
experimental_prune_transitive_depsenabled, which makes sense seeing as the non-pruning mode explicitly collects the transitive compile jars from associates.