Skip to content

Conversation

rbeazleyspot
Copy link
Contributor

@rbeazleyspot rbeazleyspot commented Jun 13, 2025

This PR fixes #1330

Previously the dep infos iterated over here

[
    d.transitive_compile_time_jars
     for d in dep_infos
  ]

included the associate dep infos thus all their transitive deps were available on the classpath.

This PR adds this back whilst still keeping any ABI jars of associates out of the classpath

I have written a test and seen it fail before applying the fix.

The scenario is as follows

    target A associates with target B
    target B has a dependency to target C
    target A uses C

what this means is the associates transitive_compile_time_jars has something a bit like this

  <generated file B.jar>,
  <generated file C.jar>,
  <source file various-sdk-libs.jar>

@Bencodes Bencodes merged commit cb8b7be into bazelbuild:master Jun 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'associates' parameter does not propagate transitive dependencies to the test target.

2 participants