README + Release Note Refresh #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the `README.md` didn't contain any details about bzlmod support + integration so thought it'd be nice to give it a small refresh. It looked like the repo integration snippet was also out of date so I decided to point it at the releases page instead like many other rulesets do; however it required adding in some of the extra repo function calls. I updated the release prep script with this and left the existing `WORKSPACE` integration snippet for now until the next release is cut with those added function calls.
sebastianv1
requested review from
Bencodes,
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
Bencodes
reviewed
Apr 7, 2025
|
|
||
| ### `MODULE.bazel` | ||
| ```python | ||
| rules_kotlin_extensions = use_extension("@rules_kotlin//src/main/starlark/core/repositories:bzlmod_setup.bzl", "rules_kotlin_extensions") |
There was a problem hiding this comment.
Really need to just split these up into internal and external so that kotlinc and ksp aren't bundled up with rest of the kotlinx deps.
Bencodes
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
README.mddidn't contain any details about bzlmod support + integration so thought it'd be nice to give it a small refresh.It looked like the repo integration snippet was also out of date so I decided to point it at the releases page instead like many other rulesets do; however it required adding in some of the extra repo function calls. I updated the release prep script with this and left the existing
WORKSPACEintegration snippet for now until the next release is cut with those added function calls.