Skip to content

Upgrade Bazel, rules_android, rules_java, and the rest of the world #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2025
Merged

Upgrade Bazel, rules_android, rules_java, and the rest of the world #1278

merged 6 commits into from
Mar 28, 2025

Conversation

Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented Feb 21, 2025 •
edited
Loading

Most notable changes included in this PR:

  • Did a large upgrade to a ton of the dependencies that we rely on. It took a ton of time to untangle the mess of version conflicts.
  • Upgrades the Ubuntu versions that we use for CI to ubuntu2404 and ubuntu2204
  • Dropped Bazel 6.x support
  • Dropped Workspace support from our rules_kotlin development lifecycle. You can still use rules_kotlin as a workspace dependency. See the examples directory for where to get started.
  • Compiles all of the example apps against the new Starlark rules_android.

@Bencodes Bencodes force-pushed the upgrade-bazel-rules_android-rules_java-and-the-rest-of-the-world branch 2 times, most recently from 23b5593 to 8615f4d Compare February 28, 2025 19:15
@Bencodes Bencodes force-pushed the upgrade-bazel-rules_android-rules_java-and-the-rest-of-the-world branch from 2b83ab3 to a1059a3 Compare March 4, 2025 00:05
@Bencodes
Copy link
Collaborator Author

@restingbull Mind giving this a review?

Bencodes
Bencodes commented Mar 26, 2025
View reviewed changes
src/test/kotlin/io/bazel/kotlin/KotlinJvmKspAssertionTest.kt
"src/test/data/jvm/ksp/CoffeeMaker.class",
"src/test/data/jvm/ksp/CoffeeMaker_Factory.class",
"src/test/data/jvm/ksp/DaggerCoffeeApp_CoffeeShop.class",
"src/test/data/jvm/ksp/DaggerCoffeeApp_CoffeeShop\$1.class",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change comes from the rules_java upgrade.

@Bencodes Bencodes merged commit e50564f into master Mar 28, 2025
2 checks passed
@Bencodes Bencodes deleted the upgrade-bazel-rules_android-rules_java-and-the-rest-of-the-world branch March 28, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@restingbull restingbull restingbull approved these changes

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@nkoroste nkoroste Awaiting requested review from nkoroste nkoroste is a code owner

Assignees

@restingbull restingbull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bencodes @restingbull