Pass module_name from kt_android_library to kt_jvm_library #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukolsak
requested review from
Bencodes,
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
|
Happy to merge this in the short term to unblock if this is causing issues, but we will be swapping these rules out with actual rules hopefully really soon. |
|
Yes, if this could be merged, that would be great. Thank you! |
restingbull
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
kt_android_librarytargets can only accessinternaldeclarations in a single otherkt_android_librarytarget, but not multiple. This is because eachkt_android_libraryhas a distinct default module name and targets in theassociatesattribute must be in the same module. This change allows users to set the module name ofkt_android_library, thus enabling multiplekt_android_librarytargets to be in the same module.