Skip to content

Require a mnemonic when calling _run_kt_builder_action #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Require a mnemonic when calling _run_kt_builder_action #1261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions kotlin/internal/jvm/compile.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ def _run_ksp_builder_actions(

def _run_kt_builder_action(
ctx,
mnemonic,
rule_kind,
toolchains,
srcs,
Expand All @@ -469,9 +470,11 @@ def _run_kt_builder_action(
transitive_runtime_jars,
plugins,
outputs,
build_kotlin = True,
mnemonic = "KotlinCompile"):
build_kotlin = True):
"""Creates a KotlinBuilder action invocation."""
if not mnemonic:
fail("Error: A `mnemonic` must be provided for every invocation of `_run_kt_builder_action`!")

kotlinc_options = ctx.attr.kotlinc_opts[KotlincOptions] if ctx.attr.kotlinc_opts else toolchains.kt.kotlinc_options
javac_options = ctx.attr.javac_opts[JavacOptions] if ctx.attr.javac_opts else toolchains.kt.javac_options

Expand Down