Skip to content

Add support for -Xconsistent-data-class-copy-visibility #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add support for -Xconsistent-data-class-copy-visibility #1247

merged 2 commits into from
Dec 18, 2024

Conversation

Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented Dec 17, 2024 •
edited
Loading

This flag is new in 2.1.0 and will likely cause a lot of compiler warnings for teams as they upgrade.

Underlying docs: https://kotlinlang.org/api/core/kotlin-stdlib/kotlin/-consistent-copy-visibility/

restingbull
restingbull approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@restingbull restingbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. That is going to be a noisy migration.

@Bencodes Bencodes merged commit c68e194 into master Dec 18, 2024
2 checks passed
@Bencodes Bencodes deleted the Bencodes-patch-8 branch December 18, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@restingbull restingbull restingbull approved these changes

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@nkoroste nkoroste Awaiting requested review from nkoroste nkoroste is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bencodes @restingbull