[toolchains] Add native.toolchain arguments to define_kt_toolchain #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
requested review from
Bencodes,
ahumesky,
cgruber and
nkoroste
as code owners
restingbull
force-pushed
the
restingbull/1206-add-exec-compat
branch
from
4acde38 to
172496b
Compare
Bencodes
reviewed
Sep 7, 2024
|
|
||
| bazel build //kotlin:stardoc || fail "docs did not generate" | ||
|
|
||
| cp -f bazel-bin/kotlin/kotlin.md docs/ || fail "couldn't copy" No newline at end of file |
There was a problem hiding this comment.
Did you intend to include this in this PR?
There was a problem hiding this comment.
Yeah, makes it easier to update the docs.
Bencodes
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1206