Fix stardoc breakage in bazel @ HEAD #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
force-pushed
the
restingbull/1182-java_common
branch
from
1164407 to
77ad146
Compare
Bencodes
approved these changes
Jul 5, 2024
restingbull
force-pushed
the
restingbull/1182-java_common
branch
2 times, most recently
from
6a4411f to
d42aa92
Compare
bazel @ head has an added dependency @rule_java_builtin java_common that is not satisfiable via import the built-in bazel srcs. Fixing this requires: * Bump `rules_java` version to one with the toolchain_utils * Import toolchain_utils from rules_java, not `bazeltools` Still a potential problem in third_party, as it will pick up toolchain_utils from `bazel_tools` -- unfortunately, the `filegroup` that won't pull in the toolchain_utils is private. :/
restingbull
force-pushed
the
restingbull/1182-java_common
branch
from
d42aa92 to
468a46b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel @ head has an added dependency @rule_java_builtin java_common that is not satisfiable via import the built-in bazel srcs.
The simplest solution it to stop using the toolchain utilities, and resolve the toolchains in a backwards compatible manner.
Still a potential problem in third_party, as it will pick up toolchain_utils from
bazel_tools-- unfortunately, thefilegroupthat won't pull in the toolchain_utils is private. :/fixes: #1180