Refactor KotlinBuilderJvmJdepsTest to do exact dep assertions #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
Bencodes
commented
Feb 23, 2024
| } | ||
| block(c.outputJar().compileKotlin()) | ||
| }) | ||
| return ctx.runCompileTask( |
There was a problem hiding this comment.
Formatting changes.
Bencodes
commented
Feb 23, 2024
| assertImplicit(jdeps).isEmpty() | ||
| assertUnused(jdeps).isEmpty() | ||
| assertIncomplete(jdeps).isEmpty() | ||
| val jdeps = depsProto(dependingTarget) |
There was a problem hiding this comment.
To de-risk this PR I left the original assertions in place until I finished making all of the new assertions pass.
restingbull
approved these changes
Mar 1, 2024
restingbull
deleted the
refactor-kotlinbuilderjvmjdepstest-to-do-exact-dep-assertions
branch
oliviernotteghem
pushed a commit
to uber-common/rules_kotlin
that referenced
this pull request
Aug 2, 2024
oliviernotteghem
pushed a commit
to uber-common/rules_kotlin
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the assertions over so that we are comparing the exact expected jdeps to the actual jdeps.
This avoids us making changes that accidentally leak types between the different dependency types.