Fix bugs with macOS test runner #2754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two major issues with the
macos_unit_test
runnerWithout
pipefail
means the exit code of thexcodebuild
command is dropped. This meant as of #2649 allmacos_unit_test
were always passing even when tests failed 🙈xcodebuild
:The fix here is to specify
variant=macos
andarch
so that xcodebuild always picks the right destination.