Skip to content

[doc] update iOS app tutorial #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aaronsky
Copy link
Contributor

@aaronsky aaronsky commented Jul 7, 2025

  • remove mentions of WORKSPACE
  • polish up the blocking, wording for consistency
  • update language around rules_xcodeproj

Fixes #2737

- remove mentions of `WORKSPACE`
- polish up the blocking, wording for consistency
- update language around rules_xcodeproj
@aaronsky aaronsky marked this pull request as ready for review July 7, 2025 23:54
Copy link
Contributor

@mattrobmattrob mattrobmattrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up. Mostly nits that we can take or leave. Mostly just like retaining the same BUILD vs. BUILD.bazel that's convention in rules_apple and rules_xcodeproj.

@aaronsky
Copy link
Contributor Author

aaronsky commented Jul 8, 2025

@mattrobmattrob thanks for the review. I was drawing from the note here about which takes precedence, and the general trend of the rest of the ecosystem towards naming build files with the extension. I don't know if there's any other reasons to choose one over the other.

@mattrobmattrob
Copy link
Contributor

My tool stack (VS Code) uses .bazel as one of the triggers to assume Starlark parsing but I don't care, really. Just nice that this doc matches the referenced examples, IMO.

@aaronsky
Copy link
Contributor Author

aaronsky commented Jul 8, 2025

@brentleyjones do you know why rules_apple/swift/xcodeproj + apple_support all use BUILD? Is it to make cherry-picking upstream easier or some other style reason? and do you have an opinion about this? (if not it's okay)

@mattrobmattrob
Copy link
Contributor

AFAIK it's just historical but cherry-picking seems like the best argument to not mess with it (in rules_apple, anyway).

@aaronsky aaronsky enabled auto-merge (squash) July 9, 2025 01:17
@aaronsky aaronsky merged commit f41bc2c into bazelbuild:master Jul 9, 2025
8 checks passed
@brentleyjones
Copy link
Collaborator

AFAIK .bazel is mainly as a backup in case you can't name it just BUILD, because you already have a build folder. Most tools know to look for BUILD in addition to *.bazel for Starlark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do you have a step by step guidline for iOS development?
3 participants