-
Notifications
You must be signed in to change notification settings - Fork 299
[doc] update iOS app tutorial #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] update iOS app tutorial #2750
Conversation
- remove mentions of `WORKSPACE` - polish up the blocking, wording for consistency - update language around rules_xcodeproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning that up. Mostly nits that we can take or leave. Mostly just like retaining the same BUILD
vs. BUILD.bazel
that's convention in rules_apple
and rules_xcodeproj
.
@mattrobmattrob thanks for the review. I was drawing from the note here about which takes precedence, and the general trend of the rest of the ecosystem towards naming build files with the extension. I don't know if there's any other reasons to choose one over the other. |
My tool stack (VS Code) uses |
@brentleyjones do you know why rules_apple/swift/xcodeproj + apple_support all use |
AFAIK it's just historical but cherry-picking seems like the best argument to not mess with it (in |
AFAIK |
WORKSPACE
Fixes #2737