Skip to content

Fix issue with codesign not supporting bundles that have spaces #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

Fix issue with codesign not supporting bundles that have spaces #2732

merged 2 commits into from
Jun 4, 2025

Conversation

adincebic
Copy link
Contributor

pranavkarthik10 and others added 2 commits June 4, 2025 08:11
@pranavkarthik10 @adincebic
Fix issue with codesign not supporting bundles that have spaces
ac33a9b 
PiperOrigin-RevId: 766808793
(cherry picked from commit 2591595)
@adincebic
Remove superfluous app_intents_tests
13880d1 
Signed-off-by: Adin Cebic <[email protected]>
mattrobmattrob referenced this pull request Jun 4, 2025
@pranavkarthik10 @swiple-rules-gardener
Fix issue with codesign not supporting bundles that have spaces
2591595 
PiperOrigin-RevId: 766808793
mattrobmattrob
mattrobmattrob approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@mattrobmattrob mattrobmattrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why'd you remove those two App Intents tests from the original commit?

@adincebic
Copy link
Contributor Author

Why'd you remove those two App Intents tests from the original commit?

Because app targets required for those tests were added in a different commit and I thought its best to not mix them. Let me know if I should add them.

@mattrobmattrob
Copy link
Contributor

Meaning that the targets don't exist without cherry picking another change, correct?

@adincebic
Copy link
Contributor Author

Meaning that the targets don't exist without cherry picking another change, correct?

Yes. I could manually add those targets though.

@mattrobmattrob mattrobmattrob merged commit 765049b into bazelbuild:master Jun 4, 2025
8 checks passed
@luispadron
Copy link
Contributor

Meaning that the targets don't exist without cherry picking another change, correct?

Yeah theres a ton of app intent changes we need to cherry pick

@adincebic adincebic deleted the adin/cherry-pick-259159545f16bfcef167b2be2d7b689b230e1c8c branch June 4, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrobmattrob mattrobmattrob mattrobmattrob approved these changes

@luispadron luispadron luispadron approved these changes

@aaronsky aaronsky Awaiting requested review from aaronsky aaronsky is a code owner

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adincebic @mattrobmattrob @luispadron @pranavkarthik10