Ability to explicitly specify output files in apple_core_data_model rule #2727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daltonclaybrook
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
May 31, 2025
luispadron
reviewed
Jun 2, 2025
|
@luispadron any thoughts on this latest change? |
luispadron
approved these changes
Jun 4, 2025
|
Looks good thanks for updating! Ill leave this here for another day or two to see if any other maintainers have thoughts then we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains one of the two fixes mentioned in #2726. This change makes it possible to explicitly specify the output files that are expected to be generated from the provided core data models. This causes the rule to return a provider containing these individual Swift files rather than just the containing folder.