-
Notifications
You must be signed in to change notification settings - Fork 300
Tests: Allow post_action to determine exit status #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this but could we make this an actual attr of the test runner in addition to an env var? It's more discoverable that way
@brentleyjones and I discussed this earlier and the reason for this approach is to allow toggling this from a |
For us I guess it doesn't matter, since we have a macro and can apply it to every instance. The environment variable has the nice effect of (1) easily applying it globally if you want (2) automatically passed into |
05fafd7
to
2db6c73
Compare
2db6c73
to
af2f32a
Compare
Add new attr
post_action_determines_exit_code
to let the test runner post action determine the exit status. Our use case is allow soft failing of certain test targets.