Skip to content

remove --nocheck_visibility flag from .bazelrc #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

remove --nocheck_visibility flag from .bazelrc #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dbf7ff
remove `--nocheck_visibility` flag from .bazelrc
aaronsky Apr 18, 2025
04c03b1
Merge branch 'master' into aaronsky/remove-nocheck_visibility-flag
aaronsky Apr 20, 2025
021b929
Merge branch 'master' into aaronsky/remove-nocheck_visibility-flag
aaronsky Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ build --test_env=PATH
# platform specific).
test --build_tests_only

# TODO(https://github.com/bazelbuild/bazel/issues/7130): Remove this flag when
# visibility and symbol import issues are resolved.
build --nocheck_visibility

# We don't need to bump some of our dependencies, just becuse our dev
# dependencies cause us to use a newer version
build --check_direct_dependencies=off
Expand Down
1 change: 1 addition & 0 deletions BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ filegroup(
name = "for_bazel_tests",
testonly = 1,
srcs = [
"BUILD",
"WORKSPACE",
"//apple:for_bazel_tests",
"//tools:for_bazel_tests",
Expand Down
1 change: 0 additions & 1 deletion test/test_rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ def apple_shell_test(
"//test:apple_shell_testutils.sh",
"//test/testdata/provisioning:integration_testing_profiles",
"//test:unittest.bash",
"//:BUILD",
] + (data or []),
deps = [
"@bazel_tools//tools/bash/runfiles",
Expand Down