-
Notifications
You must be signed in to change notification settings - Fork 302
Deduplicate linker inputs in merged linking contexts #2689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate linker inputs in merged linking contexts #2689
Conversation
//examples/multi_platform/Buttons
that exhibits the failure case
I would feel better if CI was passing before landing this. As mentioned above, I need to do more testing of this version of the patch internally as well, once I'm back from vacation. |
…atform/Buttons` that exhibits the failure case
… we've already processed in the order we encounter them
175c531
to
628a698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed our duplicate link warnings for all our top-level targets! It would be nice to be able to test the link flags for our test cases, but we can add that after
SwiftToolchainInfo
, but could have other effects.I would like any reviewers to test the patch out in their own repo before approving, using either Bazel 7 or 8, to help ensure minimal breakage.