Skip to content

xctrunner: Fix provider of platform type #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

xctrunner: Fix provider of platform type #2680

merged 1 commit into from
Apr 4, 2025

Conversation

kapoorlakshya
Copy link
Contributor

@kapoorlakshya kapoorlakshya commented Apr 1, 2025 •
edited
Loading

Was incorrectly using AppleBundleInfo instead of _TestBundleInfo.

mattrobmattrob
mattrobmattrob previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@mattrobmattrob mattrobmattrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, when is this different? Remote execution of some sort?

@mattrobmattrob
Copy link
Contributor

Actually, wondering if the if block at the top of the mutated func should be altered too now.

@mattrobmattrob mattrobmattrob dismissed their stale review April 1, 2025 23:29

Want to discuss more

@kapoorlakshya
Copy link
Contributor Author

@mattrobmattrob Hey! We started using test_suite which does not have AppleBundleInfo as a provider. _TestBundleInfo provides the required info in that situation.

mattrobmattrob
mattrobmattrob approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@mattrobmattrob mattrobmattrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good deal. Also just realized this was the new xctrunner stuff. 👍

@brentleyjones brentleyjones merged commit d0cf9d3 into bazelbuild:master Apr 4, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@mattrobmattrob mattrobmattrob mattrobmattrob approved these changes

@aaronsky aaronsky Awaiting requested review from aaronsky aaronsky is a code owner

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kapoorlakshya @mattrobmattrob @brentleyjones