Skip to content

Fix CI with Xcode 16.2 #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Apr 20, 2025
Merged

Fix CI with Xcode 16.2 #2679

merged 40 commits into from
Apr 20, 2025

Conversation

keith
Copy link
Member

@keith keith commented Mar 31, 2025 •
edited
Loading

  • CI VMs seem to be very resource constrained. system_profiler SPHardwareDataType shows 6 CPUs and 32gb of memory but I don't think that's true. This reduces the jobs and resources a lot. We can continue to play with these numbers.
  • Asset catalogs seem to take forever, I've made these exclusive, we have no large catalogs so these should all just be instant
  • xctestrunner picks the wrong simulator device type (iPhone 6s Plus), I forced that to be something newer.
  • New Xcode validates some old asset catalog issues, deleted the violations
  • Temporarily pin back last_green just to get CI green

@mattrobmattrob
Copy link
Contributor

AFAIK, we're still going to have issues with the XRSimulator stuff: bazelbuild/continuous-integration#2189 (comment)

@keith
Copy link
Member Author

keith commented Mar 31, 2025

yea looking at that too

@keith keith force-pushed the ks/test-ci-fixes branch from fa3417a to b31d2de Compare April 1, 2025 19:00
keith added 27 commits April 19, 2025 09:51
@keith keith force-pushed the ks/test-ci-fixes branch from 8f17e95 to 2938bd4 Compare April 19, 2025 16:59
@keith keith changed the title Test CI fixes Fix CI with Xcode 16.2 Apr 19, 2025
@keith keith mentioned this pull request Apr 19, 2025
Open
@keith keith marked this pull request as ready for review April 19, 2025 17:36
aaronsky
aaronsky approved these changes Apr 19, 2025
View reviewed changes
@keith keith enabled auto-merge (squash) April 19, 2025 17:47
@keith keith merged commit 262b3e5 into master Apr 20, 2025
10 checks passed
@keith keith deleted the ks/test-ci-fixes branch April 20, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsky aaronsky aaronsky approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @mattrobmattrob @aaronsky