Fix non-$should_use_xcodebuild path of test runner
#2666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert accidental inclusion of `KEEP_XCRESULT_ON_SUCCESS` * Move `xcrun llvm-profdata merge` back to where it belongs Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
requested review from
aaronsky,
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
aaronsky
approved these changes
Mar 14, 2025
mattrobmattrob
approved these changes
Mar 14, 2025
|
Want to kick off a dot release when this gets merged, @brentleyjones? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broke in fa8ce4c.
KEEP_XCRESULT_ON_SUCCESSxcrun llvm-profdata mergeback to where it belongs