Let Starlark tests inherit env variables #15217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this patch doesn't apply cleanly to the 5.x branch without also cherry-picking some of the AutoCodec refactorings. I do not know what the policy regarding this is. |
|
Hello @fmeum, Can you please check the buildkite presubmit failures. Thanks! |
|
@comius Would it be safe to cherry-pick only some of the @AutoCodec changes for Bazel 5.2.0? |
fmeum
force-pushed
the
release-5.2.0-7364
branch
4 times, most recently
from
1b50943 to
69fcfa6
Compare
|
@ckolli5 Tests are passing with minor changes applied to the cherry-picked commit. |
ckolli5
added
awaiting-review
|
@fmeum The release branch has been updated. Could you please update your branch with latest changes to release-5.2.0 branch? Thanks! |
Adds an inherited_environment field to testing.TestEnvironment to allow Starlark rules to implement the equivalent of the native rules' `env_inherit` attribute. Work towards bazelbuild#7364. To fully resolve that issue, it remains to handle executable non-test rules. RELNOTES: Starlark test rules can use the new inherited_environment parameter of testing.TestEnvironment to specify environment variables whose values should be inherited from the shell environment. Closes bazelbuild#14849. PiperOrigin-RevId: 439277689 Cherry-pick contains parts of: Delete non-interning, non-singleton @AutoCodec. PiperOrigin-RevId: 411683398 Cherry-pick makes the following additional changes: - Replace use of ImmutableMap.buildKeepingLast with .copyOf
|
@ckolli5 Done, tests pass. |
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an inherited_environment field to testing.TestEnvironment to allow
Starlark rules to implement the equivalent of the native rules'
env_inheritattribute.Work towards #7364. To fully resolve that issue, it remains to handle
executable non-test rules.
RELNOTES: Starlark test rules can use the new inherited_environment
parameter of testing.TestEnvironment to specify environment variables
whose values should be inherited from the shell environment.
Closes #14849.
PiperOrigin-RevId: 439277689
Cherry-pick contains parts of:
Delete non-interning, non-singleton @AutoCodec.
PiperOrigin-RevId: 411683398
Cherry-pick makes the following additional changes:
Closes #15240.