Expose the logic to read user netrc file #14588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
changed the title
meteorcloudy
approved these changes
Jan 20, 2022
Wyverald
reviewed
Jan 20, 2022
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Mar 7, 2022
Repository rules that download repositories from internal website often need to read users `.netrc` files. This PR exposes the logic for other repository rules to use. Closes bazelbuild#14588. PiperOrigin-RevId: 423291624 (cherry picked from commit f421474)
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Mar 7, 2022
Repository rules that download repositories from internal website often need to read users `.netrc` files. This PR exposes the logic for other repository rules to use. Closes bazelbuild#14588. PiperOrigin-RevId: 423291624 (cherry picked from commit f421474)
Wyverald
pushed a commit
that referenced
this pull request
Mar 7, 2022
Repository rules that download repositories from internal website often need to read users `.netrc` files. This PR exposes the logic for other repository rules to use. Closes #14588. PiperOrigin-RevId: 423291624 (cherry picked from commit f421474) Co-authored-by: Zhongpeng Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repository rules that download repositories from internal website often need to read users
.netrcfiles. This PR exposes the logic for other repository rules to use.