Skip to content

Show skipped tests as a warning #14235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Show skipped tests as a warning #14235

wants to merge 1 commit into from

Conversation

@brentleyjones
Copy link
Contributor

@brentleyjones brentleyjones commented Nov 5, 2021

This matches the color used for the test outputs themselves.

@brentleyjones
Show skipped test as a warning
48123d4 
This matches the color used for the test outputs themselves.
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@brentleyjones brentleyjones changed the title Show skipped test as a warning Show skipped tests as a warning Nov 5, 2021
@brentleyjones
Copy link
Contributor Author

brentleyjones commented Nov 5, 2021 •
edited
Loading

This changes the red in this output to match the magenta:
Screen Shot 2021-11-05 at 9 37 12 AM

@gregestren gregestren self-assigned this Nov 23, 2021
@gregestren gregestren added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Nov 23, 2021
@gregestren
Copy link
Contributor

gregestren commented Nov 23, 2021

@philsc

Okay, this looks cool.

@gregestren
Copy link
Contributor

gregestren commented Nov 23, 2021

@fweikert this looks like older code than the more recent incompatible target skipping @philsc and I have been involved with.

Do you have better context? Do these overlap or are these completely separate?

philsc
philsc approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@philsc philsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Thank you!

@bazel-io bazel-io closed this in 59e16e9 Nov 29, 2021
brentleyjones added a commit to brentleyjones/bazel that referenced this pull request Nov 29, 2021
@brentleyjones
Show skipped tests as a warning
577d538 
This matches the color used for the test outputs themselves.

Closes bazelbuild#14235.

PiperOrigin-RevId: 412987488
(cherry picked from commit 59e16e9)
@brentleyjones brentleyjones mentioned this pull request Nov 29, 2021
Merged
meteorcloudy pushed a commit that referenced this pull request Nov 30, 2021
@brentleyjones
Show skipped tests as a warning (#14345)
aa884df 
This matches the color used for the test outputs themselves.

Closes #14235.

PiperOrigin-RevId: 412987488
(cherry picked from commit 59e16e9)
@brentleyjones brentleyjones deleted the bj/show-skipped-test-as-a-warning branch November 30, 2021 13:51
Bencodes pushed a commit to Bencodes/bazel that referenced this pull request Jan 10, 2022
@brentleyjones @Bencodes
Show skipped tests as a warning
dcfffc5 
This matches the color used for the test outputs themselves.

Closes bazelbuild#14235.

PiperOrigin-RevId: 412987488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregestren gregestren gregestren approved these changes

+1 more reviewer

@philsc philsc philsc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gregestren gregestren

Labels

cla: yes team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brentleyjones @gregestren @philsc