Skip to content

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @rickeylev, @aignas, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think BCR is having network issues, hence the failures. Though it is odd all the failures are for gazelle.

@rickeylev
Copy link
Contributor

@meteorcloudy I know BCR is having network issues, however, the gazelle failures in this PR don't look related to that.

Did something change in how BCR presubmits are run?


ERROR: The test module directory does not exist in the source archive: /var/lib/buildkite-agent/builds/bk-docker-0q9b/bazel-org-repo-root/module_src/../examples/bzlmod_build_file_generation

I checked the archive and it does exist. Maybe its confused because rules_python_gazelle is in a subdirectory of the archive? Hence the "../examples" path.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants