[email protected] #6198
Conversation
|
Hello @kilograham, @tpudlik, modules you maintain (pico-sdk) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a pre-release version 2.2.1-develop.bcr.20250915-8fcd44a1 of the pico-sdk module. The changes are well-structured and largely adhere to the Bazel Central Registry guidelines. I have one suggestion regarding the project's MODULE.bazel file to ensure full compliance with the repository's style guide.
| module( | ||
| name = "pico-sdk", | ||
| version = "2.2.1-develop.bcr.20250915-8fcd44a1", | ||
| ) |
There was a problem hiding this comment.
According to the BCR style guide, it is strongly suggested to specify bazel_compatibility when using overlays.1 This module utilizes overlays through the build_file attribute in several repository rules.
| module( | |
| name = "pico-sdk", | |
| version = "2.2.1-develop.bcr.20250915-8fcd44a1", | |
| ) | |
| module( | |
| name = "pico-sdk", | |
| version = "2.2.1-develop.bcr.20250915-8fcd44a1", | |
| bazel_compatibility = [">=7.2.1"], | |
| ) |
Style Guide References
Footnotes
-
If using overlays, it's strongly suggested to include
bazel_compatibility>= 7.2.1. ↩
bazel-io
dismissed
their stale review
Require module maintainers' approval for newly pushed changes.
|
Fix for presubmits in #6199 |
bazel-io
dismissed
their stale review
Require module maintainers' approval for newly pushed changes.
|
Hello @davexroth, @kilograham, @tpudlik, modules you maintain (pico-sdk) have been updated in this PR. |
bazel-io
dismissed
their stale review
Require module maintainers' approval for newly pushed changes.
3 participants
Adds a pre-release of the pico-sdk that includes fixes for toolchain builtin collisions.