-
Notifications
You must be signed in to change notification settings - Fork 574
Add Swift Argument Parser 1.6.2 #6181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift Argument Parser 1.6.2 #6181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds version 1.6.2 of the swift_argument_parser module to the Bazel Central Registry. The changes are generally well-structured and follow the contribution guidelines. I have two main points of feedback: first, the MODULE.bazel file should include the bazel_compatibility attribute as recommended by the style guide to ensure forward compatibility. Second, a patch file that adds a redundant MODULE.bazel to the source archive should be removed to improve maintainability and avoid potential confusion.
modules/swift_argument_parser/1.6.2/patches/module_dot_bazel.patch
Outdated
Show resolved
Hide resolved
|
@bazel-io skip_check unstable_url |
92401f1 to
f5f6ae2
Compare
f5f6ae2 to
354b3ed
Compare
|
@keith: Friendly ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
No description provided.