Skip to content

Conversation

@pjjw
Copy link
Contributor

@pjjw pjjw commented Dec 10, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @pjjw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the available Python toolchains by integrating version 3.13.11. This update ensures that developers have access to the latest stable Python release, providing updated runtime options and maintaining compatibility across diverse operating systems and architectures for building and testing applications.

Highlights

  • New Python Version Support: Added support for Python version 3.13.11 to the project's toolchain definitions.
  • Comprehensive Platform Coverage: Included URL, SHA256 checksums, and strip_prefix configurations for Python 3.13.11 across a wide range of platforms and build types, including various Linux distributions (GNU, Musl), macOS, and Windows, with both standard and freethreaded variants.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Python toolchain version 3.13.11. The changes look correct. I've added one suggestion to sort the keys within the sha256 and strip_prefix dictionaries to improve readability and maintainability. While buildifier is disabled for this, alphabetical sorting makes it easier to find specific platforms.

Additionally, you might need to update the MINOR_MAPPING dictionary to point 3.13 to the new latest version 3.13.11. This change is outside the current diff, so I'm mentioning it here for you to consider.

Comment on lines 772 to 813
"sha256": {
"aarch64-apple-darwin": "6d01501c49e2941876293fe7196315cdb8a2fe665547b4b05a2c8e44102f781c",
"aarch64-unknown-linux-gnu": "238c7a630b7b8eab0f4e9990e7056e0a6168d515f5c8b7d21c2dbfd4db036003",
"ppc64le-unknown-linux-gnu": "186e237b8f37dc8f355e124ee73b5494f8bc47c0fe292ebb5c37e8c8091ae37e",
"riscv64-unknown-linux-gnu": "35dcb6dd6869253b694e25a7947f0903cb0a6cc8f2b5a9792cbdf3b179269769",
"s390x-unknown-linux-gnu": "7f8e37c4fc8a46175efe36481bd40fbeb0e2ae9e24e6ab1859044b1783c4eae8",
"x86_64-apple-darwin": "907c5329932222cbc6fd3acc5872a9287551adcbaa1e9cffad0422c3a3a11feb",
"x86_64-pc-windows-msvc": "1a57991904d4182932c791ef1e60b78399892802654767b6b68d3c778ca758d9",
"aarch64-pc-windows-msvc": "2b8fb19cd2cf0c16d828e6acd3807ad580c94ffa79f62cbeee2038b0f9b41e5e",
"aarch64-pc-windows-msvc-freethreaded": "af5790aa123ee6dbcde14b4a417ff70481074beb625e6d4b2bba758bbf4804b6",
"x86_64-unknown-linux-gnu": "b4538783d3ad62fc91ce43c2028558f8520b1b753cfbba17eddd8fa480a46a33",
"x86_64-unknown-linux-musl": "a8243554ab6e5a963612fd50df554a6eda01be58f89098e06dcd99ddaad9a505",
"aarch64-apple-darwin-freethreaded": "fce4697101e6c4204e6546ca3908017337897aba7a8c14eb65535cc8c60e192b",
"aarch64-unknown-linux-gnu-freethreaded": "2e32afd9c345e712861c7bafce88002b8de4c10fd4860a21773398865fe9206f",
"ppc64le-unknown-linux-gnu-freethreaded": "6dfcf803a3f926596d188d46580cd41a753b8e1a9126ea8bcd68caa3522a12b6",
"riscv64-unknown-linux-gnu-freethreaded": "43fc6051baf5e2fb91b0962a48dff51f110174def4c2f92bc82b37abd1176a0e",
"s390x-unknown-linux-gnu-freethreaded": "f48dada666ab6ef641987bbbc97ff3713395a2020a804c86a19fac02a276c06e",
"x86_64-apple-darwin-freethreaded": "8de443d36619c102507aef0a3cd95c9adb9aa9500e9ed85d07fad8becfc319e7",
"x86_64-pc-windows-msvc-freethreaded": "95786e73b39d590b3d484ac108fffe6e6dd3cd3931703397fb90179e5c55d552",
"x86_64-unknown-linux-gnu-freethreaded": "5971e366ac643ff10136ed73dcd4d37cffc968bf1f0e7af5f0c729a5479f43a5",
},
"strip_prefix": {
"aarch64-apple-darwin": "python",
"aarch64-unknown-linux-gnu": "python",
"ppc64le-unknown-linux-gnu": "python",
"s390x-unknown-linux-gnu": "python",
"riscv64-unknown-linux-gnu": "python",
"x86_64-apple-darwin": "python",
"x86_64-pc-windows-msvc": "python",
"aarch64-pc-windows-msvc": "python",
"x86_64-unknown-linux-gnu": "python",
"x86_64-unknown-linux-musl": "python",
"aarch64-apple-darwin-freethreaded": "python/install",
"aarch64-unknown-linux-gnu-freethreaded": "python/install",
"ppc64le-unknown-linux-gnu-freethreaded": "python/install",
"riscv64-unknown-linux-gnu-freethreaded": "python/install",
"s390x-unknown-linux-gnu-freethreaded": "python/install",
"x86_64-apple-darwin-freethreaded": "python/install",
"x86_64-pc-windows-msvc-freethreaded": "python/install",
"aarch64-pc-windows-msvc-freethreaded": "python/install",
"x86_64-unknown-linux-gnu-freethreaded": "python/install",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, please sort the keys in the sha256 and strip_prefix dictionaries alphabetically. This makes it easier to find a specific platform, especially in large dictionaries like these.

        "sha256": {
            "aarch64-apple-darwin": "6d01501c49e2941876293fe7196315cdb8a2fe665547b4b05a2c8e44102f781c",
            "aarch64-apple-darwin-freethreaded": "fce4697101e6c4204e6546ca3908017337897aba7a8c14eb65535cc8c60e192b",
            "aarch64-pc-windows-msvc": "2b8fb19cd2cf0c16d828e6acd3807ad580c94ffa79f62cbeee2038b0f9b41e5e",
            "aarch64-pc-windows-msvc-freethreaded": "af5790aa123ee6dbcde14b4a417ff70481074beb625e6d4b2bba758bbf4804b6",
            "aarch64-unknown-linux-gnu": "238c7a630b7b8eab0f4e9990e7056e0a6168d515f5c8b7d21c2dbfd4db036003",
            "aarch64-unknown-linux-gnu-freethreaded": "2e32afd9c345e712861c7bafce88002b8de4c10fd4860a21773398865fe9206f",
            "ppc64le-unknown-linux-gnu": "186e237b8f37dc8f355e124ee73b5494f8bc47c0fe292ebb5c37e8c8091ae37e",
            "ppc64le-unknown-linux-gnu-freethreaded": "6dfcf803a3f926596d188d46580cd41a753b8e1a9126ea8bcd68caa3522a12b6",
            "riscv64-unknown-linux-gnu": "35dcb6dd6869253b694e25a7947f0903cb0a6cc8f2b5a9792cbdf3b179269769",
            "riscv64-unknown-linux-gnu-freethreaded": "43fc6051baf5e2fb91b0962a48dff51f110174def4c2f92bc82b37abd1176a0e",
            "s390x-unknown-linux-gnu": "7f8e37c4fc8a46175efe36481bd40fbeb0e2ae9e24e6ab1859044b1783c4eae8",
            "s390x-unknown-linux-gnu-freethreaded": "f48dada666ab6ef641987bbbc97ff3713395a2020a804c86a19fac02a276c06e",
            "x86_64-apple-darwin": "907c5329932222cbc6fd3acc5872a9287551adcbaa1e9cffad0422c3a3a11feb",
            "x86_64-apple-darwin-freethreaded": "8de443d36619c102507aef0a3cd95c9adb9aa9500e9ed85d07fad8becfc319e7",
            "x86_64-pc-windows-msvc": "1a57991904d4182932c791ef1e60b78399892802654767b6b68d3c778ca758d9",
            "x86_64-pc-windows-msvc-freethreaded": "95786e73b39d590b3d484ac108fffe6e6dd3cd3931703397fb90179e5c55d552",
            "x86_64-unknown-linux-gnu": "b4538783d3ad62fc91ce43c2028558f8520b1b753cfbba17eddd8fa480a46a33",
            "x86_64-unknown-linux-gnu-freethreaded": "5971e366ac643ff10136ed73dcd4d37cffc968bf1f0e7af5f0c729a5479f43a5",
            "x86_64-unknown-linux-musl": "a8243554ab6e5a963612fd50df554a6eda01be58f89098e06dcd99ddaad9a505",
        },
        "strip_prefix": {
            "aarch64-apple-darwin": "python",
            "aarch64-apple-darwin-freethreaded": "python/install",
            "aarch64-pc-windows-msvc": "python",
            "aarch64-pc-windows-msvc-freethreaded": "python/install",
            "aarch64-unknown-linux-gnu": "python",
            "aarch64-unknown-linux-gnu-freethreaded": "python/install",
            "ppc64le-unknown-linux-gnu": "python",
            "ppc64le-unknown-linux-gnu-freethreaded": "python/install",
            "riscv64-unknown-linux-gnu": "python",
            "riscv64-unknown-linux-gnu-freethreaded": "python/install",
            "s390x-unknown-linux-gnu": "python",
            "s390x-unknown-linux-gnu-freethreaded": "python/install",
            "x86_64-apple-darwin": "python",
            "x86_64-apple-darwin-freethreaded": "python/install",
            "x86_64-pc-windows-msvc": "python",
            "x86_64-pc-windows-msvc-freethreaded": "python/install",
            "x86_64-unknown-linux-gnu": "python",
            "x86_64-unknown-linux-gnu-freethreaded": "python/install",
            "x86_64-unknown-linux-musl": "python",
        },

@pjjw pjjw force-pushed the pjjw/python-3-13-11 branch from 5c69e9b to 465e729 Compare December 11, 2025 10:27
@pjjw pjjw changed the title feat(toolchains): Add 3.13.11 feat(toolchains): Add 3.13.10, 3.13.11, 3.14.1, 3.15.0a2 Dec 11, 2025
@pjjw pjjw force-pushed the pjjw/python-3-13-11 branch from 465e729 to 5a0c92e Compare December 11, 2025 10:29
@rickeylev
Copy link
Collaborator

CI is failing on tests/python/python_tests.bzl -- I think MINOR_MAPPING needs to be updated to point to the latest versions. By default, the bzlmod selection logic takes the highest version listed in TOOL_VERSIONS.

@pjjw pjjw force-pushed the pjjw/python-3-13-11 branch from 5a0c92e to e386d3a Compare December 12, 2025 19:40
@pjjw
Copy link
Contributor Author

pjjw commented Dec 13, 2025

CI is failing on tests/python/python_tests.bzl -- I think MINOR_MAPPING needs to be updated to point to the latest versions. By default, the bzlmod selection logic takes the highest version listed in TOOL_VERSIONS.

done, still seems like some trouble with the 3.14 toolchains, though, and haven't had a ton of time to debug (just carrying a local patch in our repo for the moment)

@pjjw pjjw force-pushed the pjjw/python-3-13-11 branch from e386d3a to 780f531 Compare December 14, 2025 00:33
@pjjw pjjw changed the title feat(toolchains): Add 3.13.10, 3.13.11, 3.14.1, 3.15.0a2 feat(toolchains): Add 3.13.10, 3.13.11, 3.14.1, 3.14.2, 3.15.0a2 Dec 14, 2025
@pjjw
Copy link
Contributor Author

pjjw commented Dec 14, 2025

oops. very silly problem. blank checksums in the 3.14.1 release b/c i was going off the release notes for when the version was added, not the actual released files.. https://github.com/astral-sh/python-build-standalone/releases/tag/20251205

@pjjw pjjw force-pushed the pjjw/python-3-13-11 branch from 780f531 to 70be87b Compare December 14, 2025 00:35
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aignas aignas added this pull request to the merge queue Dec 14, 2025
Merged via the queue into bazel-contrib:main with commit 7223eb3 Dec 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants