Skip to content

Conversation

@tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Dec 10, 2025

Having mnemonics allows actions to be better identified in output, logs,
selected by flags, etc

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tyler-french, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the debuggability and clarity of Bazel build processes by introducing a specific mnemonic for the modules_mapping action. This small but impactful change allows developers to more easily track and understand the purpose of this particular build step when analyzing build outputs.

Highlights

  • Build Action Readability: A mnemonic has been added to the ctx.actions.run call within the _modules_mapping_impl function in gazelle/modules_mapping/def.bzl. This change assigns the mnemonic 'ModulesMapping' to the action, improving its identification and clarity in build logs and execution graphs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a mnemonic to one of the ctx.actions.run calls, which is a good improvement for build action visibility. I've suggested shortening the mnemonic to prevent it from being truncated in the build output. For consistency, you might also consider adding a mnemonic to the second ctx.actions.run call in the same file (which merges the mappings), for example mnemonic = "PyModMapMrg".

@tyler-french tyler-french changed the title add mnemonic to modules_mapping add missing action mnemonics Dec 10, 2025
@tyler-french tyler-french marked this pull request as ready for review December 10, 2025 15:21
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes to use PyGazelle for all the gazelle actions, to better namespace them

@rickeylev rickeylev changed the title add missing action mnemonics refactor: add mnemonics to some gazelle and sphinxdocs actions Dec 10, 2025
@rickeylev
Copy link
Collaborator

Thanks for the PR!

@rickeylev rickeylev enabled auto-merge December 10, 2025 16:32
@rickeylev rickeylev added this pull request to the merge queue Dec 10, 2025
Merged via the queue into bazel-contrib:main with commit d3ff1d1 Dec 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants