-
-
Notifications
You must be signed in to change notification settings - Fork 645
refactor: add mnemonics to some gazelle and sphinxdocs actions #3449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tyler-french, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the debuggability and clarity of Bazel build processes by introducing a specific mnemonic for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a mnemonic to one of the ctx.actions.run calls, which is a good improvement for build action visibility. I've suggested shortening the mnemonic to prevent it from being truncated in the build output. For consistency, you might also consider adding a mnemonic to the second ctx.actions.run call in the same file (which merges the mappings), for example mnemonic = "PyModMapMrg".
1335f00 to
cc0ede0
Compare
rickeylev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes to use PyGazelle for all the gazelle actions, to better namespace them
|
Thanks for the PR! |
Having mnemonics allows actions to be better identified in output, logs,
selected by flags, etc