Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Dec 6, 2025

It seems that the CI is passing now with the latest bazel 9 release.
Hence, start testing it in our CI and when submitting new versions to
BCR.

Fix #3392

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the continuous integration configurations to include Bazel 9 in the testing matrix. The primary goal is to expand test coverage to the latest Bazel version, ensuring that both general presubmit checks and Bazel Central Registry (BCR) related tests, including Gazelle-specific ones, are compatible and stable with Bazel 9.

Highlights

  • Bazel 9 Support: Added Bazel 9 to the testing matrix in .bazelci/presubmit.yml to ensure general presubmit tests are run against the latest Bazel version.
  • BCR Gazelle Tests: Updated .bcr/gazelle/presubmit.yml to include Bazel 9 in the testing matrix for Gazelle-specific Bazel Central Registry (BCR) tests.
  • General BCR Tests: Modified .bcr/presubmit.yml to incorporate Bazel 9 into the Bazel version matrix for general Bazel Central Registry (BCR) module tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add Bazel 9 to the CI test matrix for BCR tests. The changes are consistently applied across the relevant YAML configuration files (.bazelci/presubmit.yml, .bcr/gazelle/presubmit.yml, and .bcr/presubmit.yml) by adding 9.* to the bazel version list. Additionally, a helpful comment has been added to .bazelci/presubmit.yml to ensure future synchronization between related files. The changes are straightforward and correctly implement the intended expansion of CI testing. I have no further suggestions as the implementation is sound.

@aignas aignas marked this pull request as ready for review December 6, 2025 13:19
@aignas aignas requested a review from rickeylev as a code owner December 6, 2025 13:19
@rickeylev rickeylev added this pull request to the merge queue Dec 7, 2025
Merged via the queue into bazel-contrib:main with commit 2a2e136 Dec 7, 2025
4 checks passed
@aignas aignas deleted the aignas.ci.test-bazel9 branch December 7, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CI to not fail with 9.0.0-rc1

2 participants