-
-
Notifications
You must be signed in to change notification settings - Fork 636
build: change gazelle rules_python override to use bazelrc #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: change gazelle rules_python override to use bazelrc #3382
Conversation
This is because the `--override_module` flag in BCR presubmit configs can't affect local_path_override in MODULE.bazel.
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly moves the rules_python module override from MODULE.bazel to .bazelrc for the bzlmod_build_file_generation example. This change is necessary for compatibility with Bazel Central Registry (BCR) presubmits, which cannot override local_path_override directives. My feedback includes a suggestion to improve the clarity of the new comment in .bazelrc to make the reasoning more explicit for future maintainers.
| # NOTE: rules_python MUST be overridden using bazelrc config. | ||
| # This is because the BCR presubmits run with a different directory | ||
| # structure, so override this to remove the override. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment explaining the need for this override is a bit confusing, especially the phrase 'so override this to remove the override'. For better clarity and maintainability, I suggest rephrasing it to more directly explain how this change helps with BCR presubmits.
# NOTE: rules_python MUST be overridden using bazelrc config.
# This is because BCR presubmits cannot override a `local_path_override`
# in MODULE.bazel. This allows BCR presubmits to disable the override
# by passing `--override_module=rules_python=`.
This is because the `--override_module` flag in BCR presubmit configs can't affect local_path_override in MODULE.bazel. Per bazelbuild/bazel-central-registry#6241 (comment) (cherry picked from commit caab0fa)
This is because the
--override_moduleflag in BCR presubmit configs can't affect local_path_override in MODULE.bazel.Per bazelbuild/bazel-central-registry#6241 (comment)