Add support to outdated for BOMs #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
approved these changes
Mar 10, 2025
|
|
||
| Path repositoriesFile = temp.newFile("outdated.repositories").toPath(); | ||
| Files.write( | ||
| repositoriesFile, Arrays.asList("https://repo1.maven.org/maven2"), StandardCharsets.UTF_8); |
There was a problem hiding this comment.
Non-actionable comment: at some point, we should stop relying on Maven Central in our own tests since it breaks the hermeticity of the build.
|
|
||
| // artifacts might have empty versions if they come from a BOM | ||
| // In this case, skip the artifact. | ||
| if (artifactParts.length < 3) { |
There was a problem hiding this comment.
I'll close #1338 since this is the fix in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to outdated to check for outdated BOMs. Addressing #1309
The updated output looks like