Skip to content

Update bzlmod.md to remove unpinned_maven #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

mbland
Copy link
Contributor

@mbland mbland commented Jul 12, 2024

This is no longer needed as of version 6.1, thanks to:

Attn: @shs96c

Copy link

google-cla bot commented Jul 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This is no longer needed as of version 6.1, thanks to:

- bazel-contrib#1112
@mbland mbland force-pushed the bzlmod-md-rm-unpinned_maven branch from 1395988 to 7633440 Compare July 12, 2024 16:29
@shs96c
Copy link
Collaborator

shs96c commented Jul 15, 2024

@mbland It looks like you'll need to sign the CLA, either as yourself or for your employer.

@mbland
Copy link
Contributor Author

mbland commented Jul 15, 2024

@mbland It looks like you'll need to sign the CLA, either as yourself or for your employer.

I did: https://github.com/bazelbuild/rules_jvm_external/pull/1198/checks?check_run_id=27382993680

What happened was that I created the commit through the GitHub UI, which I suppose defaulted to my civilian account. I recreated it locally with my EngFlow address, force-pushed, and the CLA check passed.

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@shs96c shs96c merged commit a99d40e into bazel-contrib:master Jul 15, 2024
9 checks passed
@mbland mbland deleted the bzlmod-md-rm-unpinned_maven branch July 15, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants