Skip to content

Conversation

vinnybod
Copy link
Contributor

@vinnybod vinnybod commented Jun 26, 2024

There's two use cases I'm trying to account for here.

  1. I need to add resources to the javadoc jar such as a LICENSE file.
  2. I need to send a --define variable to the javadoc generator so that the maven_version variable I have set will appear in the <title> of the generated html. rules_jvm_external already supports the same type of substitution on the coordinates attribute.
java_export(
    name = "lib",
    maven_coordinates="com.example:lib:$(maven_version)",
    ...
    javadocopts=["-windowtitle", "$(maven_version)"],
    doc_resources = ["//:LICENSE"]
)

@vinnybod
Copy link
Contributor Author

vinnybod commented Jul 1, 2024

The CI failures seems unrelated.

ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
--
  | 🚨 Error: The command exited with status 1

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The GH UI is telling me that this has merge conflicts. Once those are resolved, I'll merge. Thank you for the PR!


import static java.nio.charset.StandardCharsets.UTF_8;

public class JarUtils {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, these a ZipUtils, but that's nit picking.

@vinnybod
Copy link
Contributor Author

vinnybod commented Sep 7, 2024

@shs96c Thanks for your review.

Apologies, but I had to reopen this PR from a different org due to permission changes. I made the update to rename JarUtils

#1238

@vinnybod vinnybod closed this Sep 7, 2024
@vinnybod vinnybod deleted the vinnybod/upstream-javadocs-updates branch September 2, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants