Propagate testonly attribute to generated plugins
#1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdesgroppes
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
rdesgroppes
force-pushed
the
regis/propagate-testonly-attribute-to-generated-plugins
branch
from
c1e040b to
06ca170
Compare
rdesgroppes
force-pushed
the
regis/propagate-testonly-attribute-to-generated-plugins
branch
5 times, most recently
from
92eb596 to
c85e899
Compare
"Generate java_plugin targets for annotation processors" (bazel-contrib#1102) brought a much-appreciated improvement by synthesizing a frequently repeated pattern. However, it doesn't work for annotation processor-related artifacts whose `testonly` attribute is set to `True`: > ERROR: /path/to/external/maven/BUILD:12345:12: in java_plugin rule > @@maven//:group_artifact__java_plugin__package_Class: non-test target > '@@maven//:group_artifact__java_plugin__package_Class' depends on > testonly target '@@maven//:group_artifact' and doesn't have testonly > attribute set The present change aims at covering the use case by taking a [Java Microbenchmark Harness](https://github.com/openjdk/jmh)-based target as a practical example. As a side note, one may run the example as follows: ```shell bazel run //tests/integration/plugin_targets:ClassUsingTestOnlyAnnotationProcessor ``` or, without `bzlmod`: ```shell bazel run --enable_bzlmod=false //tests/integration/plugin_targets:ClassUsingTestOnlyAnnotationProcessor ```
rdesgroppes
force-pushed
the
regis/propagate-testonly-attribute-to-generated-plugins
branch
from
c85e899 to
5645664
Compare
illicitonion
approved these changes
May 17, 2024
jin
approved these changes
May 17, 2024
rdesgroppes
deleted the
regis/propagate-testonly-attribute-to-generated-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Generate java_plugin targets for annotation processors" (#1102) brought a much-appreciated improvement by synthesizing a frequently repeated pattern. However, it doesn't work for annotation processor-related artifacts whose
testonlyattribute is set toTrue:The present change aims at covering the use case by taking a Java Microbenchmark Harness-based target as a practical example.
As a side note, one may run the example as follows:
or, without
bzlmod: