fix the internal archive to include all of the original dependencies #4405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
I had an issue where the go packages driver was not loading all of the dependencies in a test resulting in unresolved imports. I tracked it down to the process of recompiling for internal/external in
go_test
. For the internal archive it is filtering out the dependencies that need to be recompiled, and recompiling them, but the finalinternal_archive
does not include the recompiled dependencies. Later when the packages driver aspect lists the dependencies for thego_test
target it is missing the dependencies which were recompiled.