Support go_path rule for targets that have a dir in embedsrcs #4401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Aug 4, 2025
| target = filepath.Join(filepath.Dir(src), target) | ||
| } | ||
|
|
||
| return copyRecursively(target, dst, writeFile, createDir) |
There was a problem hiding this comment.
Could this lead out us out of the sandbox? Would it work if we only copied the symlink as is without recurring on its target?
There was a problem hiding this comment.
Could this lead out us out of the sandbox?
I don't know enough about Bazel to answer this.
Would it work if we only copied the symlink as is without recurring on its target?
I think that would only work for the copyPath function, but I don't think that would work for the ZIP archive created by archivePath, because the ZIP file cannot contain symlinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR fixes
go_pathfailing when ago_libraryrule has a directory in itsembedsrcs. It does so by correctly copying folders (as well as symlinked folders).Which issues(s) does this PR fix?
Fixes #4400
Other notes for review