Skip to content

Conversation

@fmeum
Copy link
Member

@fmeum fmeum commented Aug 15, 2025

Also enable macOS and Windows tests for all PRs.

Work towards #1146

@fmeum fmeum changed the title Update to Go 1.24.6 chore: Update to Go 1.24.6 Aug 15, 2025
@fmeum fmeum changed the title chore: Update to Go 1.24.6 chore: Update Go to 1.24.6 Aug 15, 2025
@fmeum
Copy link
Member Author

fmeum commented Aug 15, 2025

@peakschris Do you understand why Windows jobs aren't running for this PR?

@peakschris
Copy link
Contributor

Curious! Maybe this line needs relaxing?

if [[ "${{ github.ref_name }}" == "main" ]] || [[ "$HEAD_REF" == *"windows"* ]]; then

Chris

@fmeum
Copy link
Member Author

fmeum commented Aug 15, 2025

Good catch, just saw this as well and decided to drop it. Doesn't seem relevant anymore with this being part of bazel-contrib.

I'll look into cutting a release after this update.

@peakschris
Copy link
Contributor

Wonderful! love the extra windows test coverage by default 👌

@fmeum fmeum marked this pull request as ready for review August 15, 2025 14:40
@fmeum fmeum requested review from alexeagle and gregmagolan August 15, 2025 14:40
@fmeum fmeum enabled auto-merge (squash) August 15, 2025 15:12
@alexeagle alexeagle disabled auto-merge August 15, 2025 15:52
@alexeagle alexeagle merged commit fafce60 into main Aug 15, 2025
24 of 76 checks passed
@alexeagle alexeagle deleted the fmeum-patch-1 branch August 15, 2025 15:52
alexeagle pushed a commit that referenced this pull request Aug 15, 2025
Also enable macOS and Windows tests for all PRs.

Work towards #1146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants