User permissions and other issues

[dodog]

User permissions

I have accidentally discovered that a user can edit, change, and delete the admin's books.
What are the user's permissions? Can user permissions be changed so that they cannot edit or delete another user's books, just view them?

Translation bug

When searching for other user's book, the "published date" is still in English and is not localised.
But when you open the book via other user's name, list the books and then open it, the "published date" is in correct language.

Ambiguity in book's owner

When you open a book owned by another user, the same "owned" tag is displayed. This is particularly misleading if you have multiple users in family, as it gives the impression that I own the book, not another user.
Perhaps the owner (user) of the book should also be displayed in the book information panel. E.g. owned by username.

Translators are displayed as "Orphaned authors".

Is this intentional?

[bayang]

point 4 was a bug and should be fixed now.
I can't find or reproduce points 2 and 3.
Now about point 1 :
actually no one "owns" a book's data.
The technical data is shared amongst all users (ie : title, publication date, summary etc.... is the same for everyone so there is only one instance of this data in the DB).
The user specific data is private : reading events for a book, personal notes, borrowed status, owned etc....

So there are only 2 roles ; USER and ADMIN.
Everyone can add and edit a book. Once a book has been created it is available in the DB and everyone can now add it to his/her books without having to reimport it (this is the red cross you can see at the bottom of some books in search results, or in tags books, author books etc... prompting you to add it to your books).
Now when a user or an admin clicks the delete button it only deletes the user specific data and the technical data is still present in the DB so that any user can still add the book again.
An admin however, has a third option which is "delete the book for everyone" -> this option will actually delete the technical data for the book from the database and also all the user specific data. Which means that this book will be removed from all users books list if they already added it.
This part was bugged : the normal users were able to delete books technical data from the DB -> this is now fixed.
But, regular users can still edit technical data for any book present in teh DB, even books added by other users. They cannot, however, edit user specific data (events, borrowed status, personal comments etc...)

[dodog]

Thank you for the fix and for a detailed explanation. Now I understand much better how it works. I updated to v0.72.1 and I try to explain it better,

1. User permissions
User permissions does not seems to be solved in v0.72.1.
Steps to reproduce:

1. As admin user "admin1" create a test book "Test".
2. Create a user with user rights, lets say "user1".
3. Login as user1, go to Profile icon > Dashboard > Users > admin1 > Books by admin1 > Click on the book "Test" (if not visible sort by date added) > Delete > Delete this book ? - Delete.
4. Login as admin. Browse through "My books" - book "Test" is not visible. User1 removed your book.
5. Search for a book "Test". Now it shows up with red plus cross, but it is not in your library, you have to add it again.

So the books stays in database, but it is removed from the admins library.
Ideal solution would be, that user1 should be able to delete only books from his own library not from others libraries.

2. Translation bug
Sorry, my mistake, I think I was not clear enough. The actual date is not localised.
Steps to reproduce:

1. As admin1 with Slovak locale setup, search for book "Test". Published date looks like this: "Dátum vydania : 1. 1. 2025"
2. Login as user1 with Slovak locale setup, search for book "Test". Published date looks like this: "Dátum vydania : 1 January 2025".
   The date is in English.

3. Ambiguity in book's owner
Steps to reproduce

1. Login as user1, create a test book "Test" and check the "own" checkbox. Save.
2. Login as user2, go to Profile icon > Dashboard > Users > user1 > Books by user1 > Click on the book "Test".
   It shows the blue tag "owned". Suggesting that it is your book. There is not "red cross" to add the book, only the standard buttons like the book is on your library "Edit", "Delete", "Event".

[dodog]

Thank you very much, v0.72.2 solves them all.