Skip to content

fix: navigate back from last page #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iosamuel
Copy link

@iosamuel iosamuel commented Jun 8, 2022

This is a fix to improve over customized sliders with different styles than the used here by default.

Essentially the problem here was that by just having an epsilon kind of delta value of 5 (px) to check where page are we in based on the scroll position was not something reliable for custom cases where we wanna have custom spacing or different sliders widths.

So the fix is rather simple, instead of having a 5px epsilon value, we use the half of the slide width to check where we really are on the slider, doing this we don't even need to check the offset position of the slider to see if we are on the last page and force the page to be the last one (which again, is not reliable because you end up putting the user on a page he is not really at)

You can see a sample of this working here: https://codesandbox.io/s/vue-snap-xus1hx?file=/src/components/Carousel/Carousel.vue:5458-5742

  • You can navigate to the last item and start pressing the left button to navigate back, you can try changing this code to the previous code to see the error as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant