fix #1516, check inertia component array key #1525
Conversation
|
Should page.component also be used then? |
|
No,
|
src/DataCollector/ViewCollector.php
Outdated
| @@ -68,7 +68,7 @@ public function addView(View $view) | |||
| // Prevent duplicates | |||
| $hash = $type . $path . $name . $this->collect_data ? implode(array_keys($view->getData())) : ''; | |||
|
|
|||
| if (class_exists('\Inertia\Inertia') && isset($data['page'], $data['component'])) { | |||
| if (class_exists('\Inertia\Inertia') && isset($data['page'], $data['page']['component'])) { | |||
| $data = $data['page']; | |||
| $name = $data['component']; | |||
There was a problem hiding this comment.
So should this be $data['page']['component'] ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah okay, that's what I meant :P I'm just not sure how the Inertia config looks like. Don't have a demo project ready, but will try.
There was a problem hiding this comment.
I have the same problem, i just follow user indications
#1389 (comment)
You could add the other keys(props/version) for more security, although I think it would not be necessary
|
I did install Inertia on a fresh laravel app With With |
|
Wait, Now that I'm investigating Inertia, I see that there are some things missing to have full support |
fix #1516