Add nonce to <script> elements #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yannik
force-pushed
the
add-nonce-to-script-elements
branch
from
b31f59e to
66ab403
Compare
|
Combined with php-debugbar/php-debugbar#561 (which has been merged), this fixes all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configured nonce to <script> elements (or nothing, it no nonce is set, since
getNonceAttributewill then return an empty string).This does not fix all of the csp issues (embedded fonts, third party assets), but it atleast makes laravel-debugbar usable with a configured content security policy.
To set the nonce, you can use
Debugbar::getJavascriptRenderer()->setCspNonce($yourNonce);