-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix ArrayStoreException during parsing annotations #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
建议将条件隔离在单独的
/**
* 存在Druid数据源时, 加入创建器
*/
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(DruidDataSource.class)
static class DruidDataSourceCreatorConfiguration {
@Bean
@Order(DRUID_ORDER)
public DruidDataSourceCreator druidDataSourceCreator() {
return new DruidDataSourceCreator();
}
} |
@JoeyBling 确实会一些可读性问题,另外当未来注解中class的包变更时,可能在编译期不能被发现; @huayanYu 是否认 @JoeyBling 的修改方案呢,如果没问题,我可以在这个PR上修改下或你那直接修改掉; |
@itinycheng 还是用原来方案吧先,你来修复,#514 这个是否也是类似问题 |
您说的这个问题,确实可以通过全限定名解决,我指的是#514这个issue,那个问题主要是由于包依赖导致的,所以您这个提交解决不了514的问题 |
看问题描述,应该是同一个原因造成的; 我的排查结论应该就是这些; |
我在那个iusse下说明了下原因,也和这个condition机制有关吧 |
所以大家谁来提交下PR,我尽快发个版 |
是两个问题。514这个需要让AtomikosTransactionFactory这个类实现一个新接口,然后DynamicDataSourceCreatorAutoConfiguration中atomikosTransactionFactory这个Bean工厂方法返回这个接口类型,就解决了。和这个pr的内容不是一个具体原因,我得晚上提交代码,要是这个老哥有时间也可以连带提交一下 |
我先解决下当前问题吧,等会commit |
确定有这个问题么? |
@huayanYu |
@ZPZP1 跟condition机制没有关系。这就是代码的bug |
What kind of change does this PR introduce? (check at least one)
The description of the PR:
Fix for the issue: #518;
It works for me, but I didn't test it for every supported datasource.
Other information: